Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated archivePath #4979

Conversation

juergen-walter
Copy link
Contributor

@juergen-walter juergen-walter commented Sep 26, 2024

Description

Fix deprecation warning

The AbstractArchiveTask.archivePath property has been deprecated. This is
scheduled to be removed in Gradle 9.0. Please use the archiveFile property
instead. For more information, please refer to
https://docs.gradle.org/8.8/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html#org.gradle.api.tasks.bundling.AbstractArchiveTask:archivePath
in the Gradle documentation.

.archivePath has been deprecated and will be removed in Gradle 9.0. Use .archiveFile.get().asFile instead.

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged] - did not find a related issue, consider this to be a minor improvement

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Fix deprecation warning

```
The AbstractArchiveTask.archivePath property has been deprecated. This is
scheduled to be removed in Gradle 9.0. Please use the archiveFile property
instead. For more information, please refer to
https://docs.gradle.org/8.8/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html#org.gradle.api.tasks.bundling.AbstractArchiveTask:archivePath
in the Gradle documentation.
```

`.archivePath` has been deprecated and will be removed in Gradle 9.0.
Use `.archiveFile.get().asFile` instead.

Signed-off-by: Jürgen Walter <juergen.walter@sap.com>
Copy link
Collaborator

@KarstenSchnitter KarstenSchnitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing this fix.

LGTM

@dlvenable dlvenable added the maintenance Issues to help maintain the project, such as improving builds, testing, etc. label Nov 12, 2024
Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for improving the builds!

@dlvenable dlvenable merged commit d096aae into opensearch-project:main Nov 12, 2024
47 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow up maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants